-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding "perf mem" tests #2786
Adding "perf mem" tests #2786
Conversation
Test results: [root@ltcden4-lp2-test perf]# avocado run perf_mem.py -m perf_mem.py.data/record_report.yaml --max-parallel-tasks=1 Test run without YAML file[root@ltcden4-lp2-test perf]# avocado run perf_mem.py --max-parallel-tasks=1 |
Test result directory |
input_data: | ||
record_method: -i -e ldlat-stores | ||
input_data_full: | ||
record_method: --input -e ldlat-stores |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can remove these lines as -i is used with perf report
event_store_load: | ||
record_method: -e ldlat-stores -t load -f -i -v -C 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same here also, can change it to
record_method: -e ldlat-stores -t load -f -v -C 0
perf/perf_mem.py
Outdated
# file arguments for record command | ||
if self.record == "-i -e ldlat-stores": | ||
self.record = "-i %s -e ldlat-stores" % output_file | ||
elif self.record == "--input -e ldlat-stores": | ||
self.record = "--input=%s -e ldlat-stores" % output_file | ||
elif self.record == "-e ldlat-stores -t load -f -i -v -C 0": | ||
self.record = "-e ldlat-stores -t load -f \ | ||
-i %s -v -C 0" % output_file | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no need of this code after removing -i from yaml with record command
perf/perf_mem.py
Outdated
import platform | ||
import tempfile |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unused imports can be removed
Adding tests of "perf mem" command with main options called "record" and "report" with all possible options through YAML file. Signed-off-by: Shaik Abdulla <[email protected]>
7ffe140
to
ffc767c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes. LGTM
3ee8f7a
into
avocado-framework-tests:master
Code looks good to me. |
Adding tests of "perf mem" command with main options called
"record" and "report" with all possible options through YAML file.